fix: Remove empty curly brackets while verbatimModuleSyntax is on onl… #62349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y if default import is used with named import
|
This PR needs tests. |
RyanCavanaugh
requested changes
Sep 25, 2025
github-project-automation
bot
moved this from Not started
to Waiting on author
in PR Backlog
|
@jakebailey @RyanCavanaugh I added test case which verifies that empty braces are correctly removed from an import statement with a default binding and only type-only named bindings when |
RyanCavanaugh
approved these changes
Sep 26, 2025
github-project-automation
bot
moved this from Waiting on author
to Needs merge
in PR Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y if default import is used with named import
This PR fixes an issue where
verbatimModuleSyntaxwould leave empty curly braces{}in the JavaScript output when an import statement has a default import and all of its named imports are type-only.The transformer logic is updated to check for the presence of a default binding on the import code.
Fixes #62239